Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NEOS-1675: add granular permission for viewing connection credentials #3268

Merged
merged 55 commits into from
Feb 20, 2025

updates to include condition

d16fa3e
Select commit
Loading
Failed to load commit list.
Merged

NEOS-1675: add granular permission for viewing connection credentials #3268

updates to include condition
d16fa3e
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Feb 20, 2025 in 0s

24.25% (+1.52%) compared to b612c8b

View this Pull Request on Codecov

24.25% (+1.52%) compared to b612c8b

Details

Codecov Report

Attention: Patch coverage is 8.89571% with 297 lines in your changes missing coverage. Please review.

Project coverage is 24.25%. Comparing base (b612c8b) to head (d16fa3e).
Report is 9 commits behind head on main.

Files with missing lines Patch % Lines
backend/sql/postgresql/models/models.go 0.00% 118 Missing ⚠️
...rvices/mgmt/v1alpha1/user-account-service/users.go 0.00% 114 Missing ⚠️
backend/internal/userdata/entity_enforcer.go 0.00% 24 Missing ⚠️
...ces/mgmt/v1alpha1/connection-service/connection.go 0.00% 19 Missing ⚠️
backend/pkg/dbconnect-config/mssql.go 36.36% 6 Missing and 1 partial ⚠️
backend/pkg/dbconnect-config/mysql.go 75.00% 6 Missing and 1 partial ⚠️
backend/pkg/dbconnect-config/postgres.go 36.36% 6 Missing and 1 partial ⚠️
backend/internal/dtomaps/connections.go 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3268      +/-   ##
==========================================
+ Coverage   22.73%   24.25%   +1.52%     
==========================================
  Files         390      390              
  Lines       44893    45123     +230     
==========================================
+ Hits        10205    10946     +741     
+ Misses      33666    33078     -588     
- Partials     1022     1099      +77

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov