Fix truncating 0s when encoding frame #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that when serializing frames, trailing 0's weren't being truncated. I added some tests to verify this behavior.
I used pymavlink to generate some reference serialized bytes and used them as the expected value in the tests. I can include the python file I used to generate the serialized frames if that's helpful. Currently leaving it off to keep the repo tidy.
I chose to do the truncation at the
frame.serialize()level, although it could also be done at themessage.serialize()level. I feel like it made more sense at the frame level since that keeps all the CRC stuff in the same location.