fix: generate wrangler.toml in CF deployment to use bindings
#63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying nuxthub-docs with
|
| Latest commit: |
51bb1fa
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://0dc6f05e.nuxthub-module.pages.dev |
| Branch Preview URL: | https://feat-wrangler-toml.nuxthub-module.pages.dev |
|
this is definitely conflicting with nitro in the future... :( |
|
Following our call with @pi0 about the best way forward and his work on nitrojs/nitro#2353 (thank you!) The NuxtHub API should send back a wrangler in a JSON format as Nitro uses confbox to generate the Instead of generating the nuxt.options.nitro.cloudflare.wrangler = defu(wranglerConfigFromNuxtHub, nuxt.options.nitro.cloudflare.wrangler)So far Cloudflare Pages CI is reading from the Also, I am not sure that we should have the nitro.cloudflare.wranglerPath // default to join(nitro.options.rootDir, 'wrangler.toml')
nitro.cloudflare.wranglerOutputPath // default to join(nitro.options.output.publicDir, 'wrangler.toml') |
farnabaz
changed the title
wrangler.toml in CF deployment to use bindingswrangler.toml in CF deployment to use bindings
atinux
reviewed
Apr 11, 2024
atinux
reviewed
Apr 11, 2024
atinux
approved these changes
Apr 11, 2024
Aslemammad
pushed a commit
to Aslemammad/nuxt-core
that referenced
this pull request
Jun 12, 2024
…hub#63) * fix: generate `wrangler.toml` in CF deployment to use bindings * up * fix: environment variables * up * up * chore: update to use wrangler object * chore: use nitropack-nightly * fix: await bundling for openapi * cohre: add todo * fix: warn and exit when changes detected in bindings * fix: remove nitro nightly * chore: up * Update src/runtime/server/api/_hub/openapi.get.ts * Update src/utils.ts --------- Co-authored-by: Sébastien Chopin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.