Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(PostPage): fix surround order #2985

Merged
merged 1 commit into from
Jan 17, 2025
Merged

docs(PostPage): fix surround order #2985

merged 1 commit into from
Jan 17, 2025

Conversation

maximepvrt
Copy link
Contributor

@maximepvrt maximepvrt commented Jan 16, 2025

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

@farnabaz There is still an issue with the surround links being in the wrong order at the bottom.

Capture d’écran 2025-01-16 aΜ€ 18 09 40

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@maximepvrt maximepvrt mentioned this pull request Jan 16, 2025
7 tasks
Copy link

pkg-pr-new bot commented Jan 16, 2025

npm i https://pkg.pr.new/@nuxt/content@2985

commit: 2e76f0b

@farnabaz
Copy link
Member

Isn't this true order? I think previous items should be on the left side. They are similar to the back button just above them.

Correct me if I'm wrong @benjamincanac

@maximepvrt
Copy link
Contributor Author

@farnabaz All previous links are currently on the right, and next links are on the left. You can see an example of this behavior on this page: https://nuxt.com/blog/v3-15. It would work perfectly if the order followed the same logic as listing all the articles here: https://github.com/nuxt/content/blob/main/docs/app/pages/blog/index.vue#L14.

However, it might make sense to reverse the order if the locale uses a right-to-left (RTL) reading direction. What do you think?

@farnabaz
Copy link
Member

It is worth waiting for @benjamincanac opinion about this. As I see in ContentSurround component, the previous item should have direction="left" attribute which matches the current order.

    <ReuseLinkTemplate :link="surround[0]"... direction="left" />
    <ReuseLinkTemplate :link="surround[1]" ... direction="right" />

@farnabaz
Copy link
Member

Well, I had a quick chat with Benjamin, and seems that I got it wrong.
Thanks for the PR @maximepvrt ❀️

@farnabaz farnabaz merged commit 49412ee into nuxt:main Jan 17, 2025
3 checks passed
@farnabaz farnabaz mentioned this pull request Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants