When script fails with exit code 1 we want to see the reason in logs #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #106 +/- ##
==========================================
- Coverage 64.58% 64.20% -0.39%
==========================================
Files 5 5
Lines 336 338 +2
==========================================
Hits 217 217
- Misses 99 101 +2
Partials 20 20
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
andywaltlova
force-pushed
the
feat/use-combinedoutput-for-collection
branch
from
b891f61 to
b94f7ad
Compare
andywaltlova
force-pushed
the
feat/use-combinedoutput-for-collection
branch
from
b94f7ad to
cbcd0b2
Compare
Use case: problem in covnersion script when script exited with 1 but we had to manually reproduce the situation to see which part of code was problematic Signed-off-by: Andrea Waltlova <[email protected]>
andywaltlova
force-pushed
the
feat/use-combinedoutput-for-collection
branch
from
cbcd0b2 to
2905cb0
Compare
r0x0d
approved these changes
Dec 1, 2023
|
I will wait with this one, I want to test it locally in vagrant box to make sure the error and exit code don't fail, we would have to make new release anyway. |
andywaltlova
changed the title
as per logs and tests in vagrant box if script exits with one it is contained in the er itself Signed-off-by: Andrea Waltlova <[email protected]>
|
Alright, looks alright to me! Below is the log when I made syntax error in python script (=makes the execution end with exit code 1), I removed the duplicate exit status log from this MR since it is in the |
r0x0d
approved these changes
Dec 5, 2023
|
@andywaltlova, please go ahead. I'm afraid that this won't land in the worker for quite some time now. I think we can only do a release next year as we are out of time for pushing any releases right now. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use case: problem in conversion script when script exited with 1 but we had to manually reproduce the situation to see which part of code was problematic
Related to oamg/convert2rhel-insights-tasks#46