-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Read script stdout and wrap it in required json format #31
Read script stdout and wrap it in required json format #31
Conversation
4392f05
to
b751d6c
Compare
5155c01
to
7c073f3
Compare
Signed-off-by: Andrea Waltlova <[email protected]>
7c073f3
to
52968ba
Compare
development/nginx/command
Outdated
echo "BEGIN MARKER" | ||
echo "$data" | ||
echo "END MARKER" | ||
/usr/bin/convert2rhel --version |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would only invert the order of execution here... Ideally, the marker will be the last thing in the output, and the tool that is running will come just before it.
Thinking about the idea that the script will "read" the output of the tool that just run, I think it makes sense that the tool runs before the marker. Let me know what you think.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, I have no problem with that, when I was reading the description I just though that if it should be generic that It shouldn't matter to insights where the output is in the stdout as long as it is between the markers it will get shown. That is why I put command before and after the markers.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Inverted, commands are firsts then the content within markers
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Only one comment about the order of execution of the initial script. other than that, I think we are ready to merge.
Signed-off-by: Andrea Waltlova <[email protected]>
52968ba
to
200c89f
Compare
HMS-2005
Replace dumb read of json file with json containing
correlation_id
andstdout
Content of file that is sent to
api/ingress/v1/upload
(in local development proxied to minio) with output fromdate
command looks like this:Works same with
/usr/bin/convert2rhel --help
see attached file - 66ZLDMZKn4-000001.txt