Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to create config for rhc-worker-bash #50

Merged
merged 1 commit into from
Jul 19, 2023

Conversation

andywaltlova
Copy link
Collaborator

Fixes #41

Yaml config at '/etc/rhc/workers/rhc-worker-bash.yml' can now change behavior of worker, this is similar to rhc-worker-playbook (they have toml config, but since we are already using yaml module our config is also yaml)

@codecov-commenter
Copy link

codecov-commenter commented Jul 19, 2023

Codecov Report

Patch coverage: 70.58% and project coverage change: +0.62 🎉

Comparison is base (8dd21f3) 60.91% compared to head (1d9672c) 61.53%.

❗ Current head 1d9672c differs from pull request most recent head 98cb943. Consider uploading reports for the commit 98cb943 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #50      +/-   ##
==========================================
+ Coverage   60.91%   61.53%   +0.62%     
==========================================
  Files           5        5              
  Lines         284      325      +41     
==========================================
+ Hits          173      200      +27     
- Misses         97      110      +13     
- Partials       14       15       +1     
Flag Coverage Δ
go-1.20 61.53% <70.58%> (+0.62%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/main.go 0.00% <0.00%> (ø)
src/util.go 78.57% <93.47%> (+4.65%) ⬆️
src/runner.go 79.34% <100.00%> (+0.22%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@andywaltlova andywaltlova force-pushed the feat/add-optional-config branch 2 times, most recently from 3357273 to 1d9672c Compare July 19, 2023 12:45
yaml config at /etc/rhc/workers/rhc-worker-bash.yml can now change behavior of worker
@andywaltlova andywaltlova force-pushed the feat/add-optional-config branch from 1d9672c to 98cb943 Compare July 19, 2023 12:46
@andywaltlova andywaltlova merged commit 9e34489 into oamg:main Jul 19, 2023
@r0x0d r0x0d mentioned this pull request Aug 10, 2023
@andywaltlova andywaltlova deleted the feat/add-optional-config branch August 17, 2023 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create proper config file
2 participants