Improve logging when insights_core_gpg_check is disabled #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r0x0d
force-pushed
the
update-signature-logging
branch
3 times, most recently
from
18e59f2 to
e05c994
Compare
r0x0d
changed the title
r0x0d
changed the title
andywaltlova
requested changes
Sep 26, 2023
There was a problem hiding this comment.
Have a question, based on the changes it's not clear to me why the gpg check even exists 😅 So we have basically four cases right?
- verification enabled, gpg check enabled
- insights client call without
--no-gpg
- insights client call without
- verification enabled, gpg check disabled
- this is my question - this should append the
--no-gpgoption to insights client verification call?
- this is my question - this should append the
- verification disabled, gpg enabled
- verification and gpg should be skipped, no insights-client call
- verification disabled, gpg disabled
- verification simply disabled, no insights-client call
r0x0d
force-pushed
the
update-signature-logging
branch
3 times, most recently
from
2599303 to
8a5f99e
Compare
Update the logs that related to the signature verification. Now it is more clear to the user that the insights-client call will still occur, but the result may be ignored because the validation is disabled. Signed-off-by: Rodolfo Olivieri <[email protected]>
r0x0d
force-pushed
the
update-signature-logging
branch
from
8a5f99e to
a9f6a4c
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #90 +/- ##
==========================================
- Coverage 65.61% 65.34% -0.28%
==========================================
Files 5 5
Lines 349 352 +3
==========================================
+ Hits 229 230 +1
- Misses 100 101 +1
- Partials 20 21 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
andywaltlova
approved these changes
Sep 29, 2023
Co-authored-by: Andrea Waltlová <[email protected]>
andywaltlova
approved these changes
Sep 29, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the user specify that the insights gpg check should be disabled, we should do nothing and execute the script anyway, as there is no gpg check to be performed. Otherwise, if the gpg check is still enabled, we call insights-client to verify the signature.
If there is no need to validate the gpg signature, we should not call insights-client for it.
HMS-2647