cli: Initial Oasis CLI #595

kostko · 2021-10-29T12:59:00Z

No description provided.

codecov · 2021-10-29T13:00:47Z

Codecov Report

Merging #595 (c293cfc) into main (3b19fa1) will decrease coverage by 1.53%.
The diff coverage is 28.10%.

@@            Coverage Diff             @@
##             main     #595      +/-   ##
==========================================
- Coverage   73.07%   71.54%   -1.54%     
==========================================
  Files         102      109       +7     
  Lines        7777     8051     +274     
==========================================
+ Hits         5683     5760      +77     
- Misses       2072     2268     +196     
- Partials       22       23       +1

Impacted Files	Coverage Δ
client-sdk/go/config/denomination.go	`0.00% <0.00%> (ø)`
client-sdk/go/config/network.go	`0.00% <0.00%> (ø)`
client-sdk/go/config/paratime.go	`0.00% <0.00%> (ø)`
client-sdk/go/modules/contracts/contracts.go	`0.00% <0.00%> (ø)`
client-sdk/go/modules/contracts/types.go	`40.00% <0.00%> (-60.00%)`	⬇️
client-sdk/go/types/address.go	`56.96% <0.00%> (-3.04%)`	⬇️
client-sdk/go/types/transaction.go	`61.80% <0.00%> (-0.88%)`	⬇️
client-sdk/go/helpers/denomination.go	`88.46% <88.46%> (ø)`
client-sdk/go/config/identifier.go	`100.00% <100.00%> (ø)`
client-sdk/go/helpers/address.go	`100.00% <100.00%> (ø)`
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b19fa1...c293cfc. Read the comment docs.

pro-wh · 2021-11-22T21:40:33Z

~~going to rebase and merge!~~ lmao wrong tab. definitely not

matevz

First pass, some minor questions.

matevz · 2021-11-29T10:48:29Z

cli/cmd/contracts.go

+
+	contractsCmd = &cobra.Command{
+		Use:   "contracts",
+		Short: "WebAssembly smart contracts operations",


This is for Cipher paratime only, right?

Currently yes, but in theory for any ParaTime that includes the contracts module.

cli/config/network.go

cli/main.go

cli/cmd/root.go

Yawning · 2022-01-05T11:57:46Z

Bikeshedding this to hell and back is great and all, but it has utility functions that I need for other work.

cli/go.mod

.gitignore

cli/cmd/network.go

tjanez · 2022-01-05T12:47:46Z

cli/cmd/network.go

+			questions := []*survey.Question{
+				{
+					Name:   "description",
+					Prompt: &survey.Input{Message: "Description:"},


There is a bit of an inconsistency. In the oasis network list we use NAME and here we ask for Description.
I'm slightly more in favor of using Name here and perhaps network_name for the variables to avoid confusion with all other Name things in this part of the code 🙂

So there are two things, "name" and "description". The name is an identifier used in various places to reference networks, paratimes etc. while "description" is something human readable that is also shown when signing a transaction.

tjanez · 2022-01-05T12:55:44Z

cli/cmd/network.go

+	}
+
+	networkRmCmd = &cobra.Command{
+		Use:     "rm <name>",


This doesn't need to be resolved in this PR, but could the shell completion be configured to list all the networks' names when one presses Tab after typing:

oasis network rm

Yeah this should be done in a separate PR, feel free to file an issue once this is merged.

cli/README.md

cli/cmd/root.go

tjanez · 2022-01-05T13:04:44Z

cli/cmd/root.go

+		configPath := filepath.Join(configDir, configFilename)
+
+		v.AddConfigPath(configDir)
+		v.SetConfigType("toml")


Do you think TOML will be better for the users 🙂 ?
I'm a bit more in favor or YAML 🙂

Yawning · 2022-01-05T13:35:59Z

Since I'm blocked on this, I might as well request changes too:

Can you move cli/client to somewhere inside the actual client SDK so that people writing tooling aren't stuck either reimplementing it or pulling it in from the CLI.
Likewise, can you move cli/common/demonimation to somewhere inside the actual client SDK?

tjanez · 2022-01-05T14:34:45Z

Since I'm blocked on this, I might as well request changes too:

* Can you move cli/client to somewhere inside the actual client SDK so that people writing tooling aren't stuck either reimplementing it or pulling it in from the CLI.

* Likewise, can you move cli/common/demonimation to somewhere inside the actual client SDK?

Yeah and perhaps extract this in a separate commit and PR so it can be reviewed and merged earlier?

Yawning · 2022-01-06T01:01:14Z

Also config.ResolveAddress and all the other helpers that let me go from a paratime ID + account to a transaction would make my life easier.

kostko · 2022-01-06T10:55:52Z

Moved some of the config, connection and helpers stuff to the Go Client SDK.

kostko · 2022-01-06T13:22:52Z

I'll merge the PR and we can improve the CLI in subsequent PRs.

pro-wh · 2022-01-12T19:47:54Z

client-sdk/go/config/default.go

+		// See https://docs.oasis.dev/general/oasis-network/network-parameters.
+		"mainnet": {
+			ChainContext: "53852332637bacb61b91b6411ab4095168ba02a50be4c3f82448438826f23898",
+			RPC:          "grpc.oasis.dev:443",


resposting as this was lost in a file move:

does the grpc-web proxy lets us dial it from the normal grpc client? or is there an additional thing on that server that handles normal grpc?

kostko force-pushed the kostko/feature/cli branch 4 times, most recently from 08f5bd5 to 5158988 Compare November 5, 2021 12:53

kostko requested a review from tjanez November 8, 2021 12:58

kostko force-pushed the kostko/feature/cli branch 6 times, most recently from aacb4b3 to 993d02a Compare November 15, 2021 19:03

kostko force-pushed the kostko/feature/cli branch 7 times, most recently from 92e26a0 to b80b7fd Compare November 22, 2021 18:58

kostko force-pushed the kostko/feature/cli branch 3 times, most recently from ee4acfd to d47d139 Compare November 29, 2021 09:40

matevz reviewed Nov 29, 2021

View reviewed changes

kostko force-pushed the kostko/feature/cli branch 4 times, most recently from 3e5ff85 to d5d89e5 Compare December 10, 2021 09:09

kostko marked this pull request as ready for review December 10, 2021 09:09

kostko requested a review from pro-wh as a code owner December 10, 2021 09:09

kostko force-pushed the kostko/feature/cli branch 7 times, most recently from 44042ef to 85f1649 Compare January 5, 2022 11:13

tjanez reviewed Jan 5, 2022

View reviewed changes

cli/main.go Show resolved Hide resolved

cli/cmd/root.go Show resolved Hide resolved

kostko force-pushed the kostko/feature/cli branch from 85f1649 to 3516a98 Compare January 5, 2022 12:09

tjanez reviewed Jan 5, 2022

View reviewed changes

cli/go.mod Outdated Show resolved Hide resolved

tjanez reviewed Jan 5, 2022

View reviewed changes

.gitignore Show resolved Hide resolved

cli/cmd/network.go Show resolved Hide resolved

kostko force-pushed the kostko/feature/cli branch from 3516a98 to ac8e394 Compare January 5, 2022 12:55

tjanez reviewed Jan 5, 2022

View reviewed changes

kostko force-pushed the kostko/feature/cli branch 2 times, most recently from e8c117a to a393d1c Compare January 6, 2022 10:55

kostko force-pushed the kostko/feature/cli branch from a393d1c to 871f556 Compare January 6, 2022 11:04

cli: Initial Oasis CLI

c293cfc

kostko force-pushed the kostko/feature/cli branch from 871f556 to c293cfc Compare January 6, 2022 11:31

kostko merged commit 89850c7 into main Jan 6, 2022

kostko deleted the kostko/feature/cli branch January 6, 2022 13:23

pro-wh reviewed Jan 12, 2022

View reviewed changes

kostko mentioned this pull request Feb 4, 2022

CLI utility for compiling and deploying smart contracts #371

Closed

tjanez pushed a commit to oasisprotocol/cli that referenced this pull request Sep 20, 2022

Initial Oasis CLI (oasisprotocol/oasis-sdk#595)

3c3921e

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

cli: Initial Oasis CLI #595

cli: Initial Oasis CLI #595

kostko commented Oct 29, 2021

codecov bot commented Oct 29, 2021 •

edited

Loading

pro-wh commented Nov 22, 2021 •

edited

Loading

matevz left a comment

matevz Nov 29, 2021

kostko Dec 7, 2021

Yawning commented Jan 5, 2022

tjanez Jan 5, 2022

kostko Jan 6, 2022

tjanez Jan 5, 2022

kostko Jan 5, 2022

tjanez Jan 5, 2022

Yawning commented Jan 5, 2022

tjanez commented Jan 5, 2022

Yawning commented Jan 6, 2022 •

edited

Loading

kostko commented Jan 6, 2022

kostko commented Jan 6, 2022

pro-wh Jan 12, 2022 •

edited

Loading

cli: Initial Oasis CLI #595

cli: Initial Oasis CLI #595

Conversation

kostko commented Oct 29, 2021

codecov bot commented Oct 29, 2021 • edited Loading

Codecov Report

pro-wh commented Nov 22, 2021 • edited Loading

matevz left a comment

Choose a reason for hiding this comment

matevz Nov 29, 2021

Choose a reason for hiding this comment

kostko Dec 7, 2021

Choose a reason for hiding this comment

Yawning commented Jan 5, 2022

tjanez Jan 5, 2022

Choose a reason for hiding this comment

kostko Jan 6, 2022

Choose a reason for hiding this comment

tjanez Jan 5, 2022

Choose a reason for hiding this comment

kostko Jan 5, 2022

Choose a reason for hiding this comment

tjanez Jan 5, 2022

Choose a reason for hiding this comment

Yawning commented Jan 5, 2022

tjanez commented Jan 5, 2022

Yawning commented Jan 6, 2022 • edited Loading

kostko commented Jan 6, 2022

kostko commented Jan 6, 2022

pro-wh Jan 12, 2022 • edited Loading

Choose a reason for hiding this comment

codecov bot commented Oct 29, 2021 •

edited

Loading

pro-wh commented Nov 22, 2021 •

edited

Loading

Yawning commented Jan 6, 2022 •

edited

Loading

pro-wh Jan 12, 2022 •

edited

Loading