Use #![no_std] in test crates wherever feasible.
#798
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the original code: ``` generate rustdoc JSON: real 0m20.535s user 0m17.535s sys 0m2.646s cargo test: real 0m1.223s user 0m11.498s sys 0m0.737s 19MB in localdata/test_data ``` With `#![no_std]` where easily feasible: ``` generate rustdoc JSON: real 0m15.892s user 0m13.102s sys 0m2.543s cargo test: real 0m1.070s user 0m10.122s sys 0m0.791s 8.6MB in localdata/test_data ```
obi1kenobi
added a commit
that referenced
this pull request
Mar 7, 2025
In the original code: ``` generate rustdoc JSON: real 0m20.535s user 0m17.535s sys 0m2.646s cargo test: real 0m1.223s user 0m11.498s sys 0m0.737s 19MB in localdata/test_data ``` With `#![no_std]` where easily feasible: ``` generate rustdoc JSON: real 0m15.892s user 0m13.102s sys 0m2.543s cargo test: real 0m1.070s user 0m10.122s sys 0m0.791s 8.6MB in localdata/test_data ```
obi1kenobi
added a commit
that referenced
this pull request
Mar 7, 2025
In the original code: ``` generate rustdoc JSON: real 0m20.535s user 0m17.535s sys 0m2.646s cargo test: real 0m1.223s user 0m11.498s sys 0m0.737s 19MB in localdata/test_data ``` With `#![no_std]` where easily feasible: ``` generate rustdoc JSON: real 0m15.892s user 0m13.102s sys 0m2.543s cargo test: real 0m1.070s user 0m10.122s sys 0m0.791s 8.6MB in localdata/test_data ```
obi1kenobi
added a commit
that referenced
this pull request
Mar 7, 2025
In the original code: ``` generate rustdoc JSON: real 0m20.535s user 0m17.535s sys 0m2.646s cargo test: real 0m1.223s user 0m11.498s sys 0m0.737s 19MB in localdata/test_data ``` With `#![no_std]` where easily feasible: ``` generate rustdoc JSON: real 0m15.892s user 0m13.102s sys 0m2.543s cargo test: real 0m1.070s user 0m10.122s sys 0m0.791s 8.6MB in localdata/test_data ```
obi1kenobi
added a commit
that referenced
this pull request
Mar 7, 2025
In the original code: ``` generate rustdoc JSON: real 0m20.535s user 0m17.535s sys 0m2.646s cargo test: real 0m1.223s user 0m11.498s sys 0m0.737s 19MB in localdata/test_data ``` With `#![no_std]` where easily feasible: ``` generate rustdoc JSON: real 0m15.892s user 0m13.102s sys 0m2.543s cargo test: real 0m1.070s user 0m10.122s sys 0m0.791s 8.6MB in localdata/test_data ```
obi1kenobi
added a commit
that referenced
this pull request
Mar 7, 2025
In the original code: ``` generate rustdoc JSON: real 0m20.535s user 0m17.535s sys 0m2.646s cargo test: real 0m1.223s user 0m11.498s sys 0m0.737s 19MB in localdata/test_data ``` With `#![no_std]` where easily feasible: ``` generate rustdoc JSON: real 0m15.892s user 0m13.102s sys 0m2.543s cargo test: real 0m1.070s user 0m10.122s sys 0m0.791s 8.6MB in localdata/test_data ```
obi1kenobi
added a commit
that referenced
this pull request
Mar 7, 2025
In the original code: ``` generate rustdoc JSON: real 0m20.535s user 0m17.535s sys 0m2.646s cargo test: real 0m1.223s user 0m11.498s sys 0m0.737s 19MB in localdata/test_data ``` With `#![no_std]` where easily feasible: ``` generate rustdoc JSON: real 0m15.892s user 0m13.102s sys 0m2.543s cargo test: real 0m1.070s user 0m10.122s sys 0m0.791s 8.6MB in localdata/test_data ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the original code:
With
#![no_std]where easily feasible: