Avoid using 'eval' for statically known strings #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OlivierNicole
force-pushed
the
avoid_eval
branch
from
1f0a9eb to
9ddbe64
Compare
When using functions such as `Js.Unsafe.eval_string` in Wasm, when the string is known at compile time, it can be emitted as an external Javascript fragment, rather than using the infamous `eval`. Co-authored-by: Jérôme Vouillon <[email protected]>
OlivierNicole
force-pushed
the
avoid_eval
branch
from
9ddbe64 to
0a8a736
Compare
|
Could you reformat |
|
Done. |
vouillon
reviewed
Mar 15, 2024
runtime/wasm/runtime.js
Outdated
Comment on lines
363
to
383
| start_fiber = wrap_fun( | ||
| {parameters: ['eqref'], results: ['externref']}, | ||
| caml_start_fiber, {promising: 'first'} | ||
| ) | ||
| var _initialize = wrap_fun( | ||
| {parameters: [], results: ['externref']}, | ||
| _initialize, {promising: 'first'} | ||
| ) | ||
| var process = globalThis.process; | ||
| if(process && process.on) { | ||
| process.on('uncaughtException', (err, origin) => | ||
| caml_handle_uncaught_exception(err)) | ||
| } | ||
| else if(globalThis.addEventListener){ | ||
| globalThis.addEventListener('error', event=> | ||
| event.error&&caml_handle_uncaught_exception(event.error)) | ||
| } | ||
| await _initialize(); | ||
| })(((joo_global_object,jsoo_exports,globalThis)=>(x)=>{return eval("("+x+")")})(globalThis,globalThis?.module?.exports||globalThis,globalThis), | ||
| PRIMITIVES, STRINGS, | ||
| ((joo_global_object,jsoo_exports,globalThis)=>FRAGMENTS)(globalThis,globalThis?.module?.exports||globalThis,globalThis)) |
There was a problem hiding this comment.
Not sure what happened here. I think it should be right now?
There was a problem hiding this comment.
@vouillon I don’t really understand this file, so I don’t remember what was the right way to do this.
OlivierNicole
force-pushed
the
avoid_eval
branch
from
94ba315 to
1a8fc19
Compare
vouillon
reviewed
Mar 18, 2024
Co-authored-by: Jérôme Vouillon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using functions such as
Js.Unsafe.eval_stringin Wasm, when the string is known at compile time, it can be emitted as an external Javascript fragment, rather than using the infamouseval.