Fix #587 #603
Fix #587 #603
Conversation
jonludlam
force-pushed
the
shadowed-v2
branch
from
0e3159d to
0be71b4
Compare
Signed-off-by: Jon Ludlam <[email protected]>
This still isn't quite right, but it's definitely less wrong with this fix. Signed-off-by: Jon Ludlam <[email protected]>
jonludlam
force-pushed
the
shadowed-v2
branch
from
0be71b4 to
50926f2
Compare
src/xref2/lang_of.ml
Outdated
| if List.mem name map.shadowed.s_types then | ||
| `Type | ||
| ( parent, | ||
| Odoc_model.Names.TypeName.internal_of_string (Ident.Name.type_ id) |
There was a problem hiding this comment.
| Odoc_model.Names.TypeName.internal_of_string (Ident.Name.type_ id) | |
| Odoc_model.Names.TypeName.internal_of_string name |
| @@ -0,0 +1,19 @@ | |||
| #!/bin/sh | |||
There was a problem hiding this comment.
| #!/bin/sh | |
| #!/usr/bin/env sh |
Otherwise, this script can be inlined into run.t.
There was a problem hiding this comment.
I find it quite helpful to have the script external as it's easier to run and find the output - particularly for those that output html that I'd like to look at (not this one, as it happens). Is there a better way to do this?
There was a problem hiding this comment.
My preferred way is to add commands to the run.t file, I usually add $ find . then cat some files. I do dune runtest --auto-promote test/xref2 to increase speed (I have a binding in my editor for that).
That way I'm sure everything is run from scratch and I avoid inconsistent states.
There was a problem hiding this comment.
OK, that's fine for just seeing the content of the files but I often want to see the HTML output in the browser. I suppose that's really only when developing the test, so I can always transcribe it into the run.t afterwards, as I agree it's better to have it inline.
The error was due to a bug in the shadowing code, which manifests due to
Subst'srecent tightening in the PR to improve speed.