Add anchors to type extensions #684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This only adds the anchor in the html backend, it is not possible to reference type extensions. The anchor is "extension-decl-FirstConstructor". This should be enough because it is not possible to have two constructors of the same name in the same signature.
Huh, that's actually probably right, I somehow didn't realized that. I think it's the last one! Can you try to get rid of the option type for anchors ? :) |
|
There are some other |
|
Right, we should anchor those eventually too. |
|
I don't think this completely fixes #601 as there's no way to refer to these things from within the doc itself (ie, there's no |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #601
This PR adds anchors to type extensions but doesn't allow them to be referenced.
The anchor looks like
extension-decl-FirstConstructor. This is enough because it's not possible to have two constructors with the same name in a signature.The other part of the issue is fixed since #615
This is the simplest fix for the issue. An alternative is to add an internal name and a new syntax for references to extensions.