Cms module refactor #3575
Closed
Cms module refactor #3575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LukeTowers
reviewed
Jun 1, 2018
|
@w20k could you review this? |
|
On it @LukeTowers |
w20k
reviewed
Dec 13, 2018
added 4 commits
March 14, 2019 09:24
Merge Upstream Changes
…ctober into cms-module-refactor
|
This pull request will be closed and archived in 3 days, as there has been no activity in the last 30 days. If this is still being worked on, please respond and we will re-open this pull request. |
|
This pull request will be closed and archived in 3 days, as there has been no activity in the last 30 days. If this is still being worked on, please respond and we will re-open this pull request. |
|
This pull request will be closed and archived in 3 days, as there has been no activity in the last 30 days.
|
|
Closing - this PR appears to be abandoned. |
LukeTowers
added a commit
to wintercms/winter
that referenced
this pull request
Feb 18, 2022
Credit to @SeriousKen for the original work in octobercms/october#3575
LukeTowers
added a commit
to wintercms/wn-system-module
that referenced
this pull request
Feb 18, 2022
Credit to @SeriousKen for the original work in octobercms/october#3575
LukeTowers
added a commit
to wintercms/wn-cms-module
that referenced
this pull request
Feb 18, 2022
Credit to @SeriousKen for the original work in octobercms/october#3575
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a refactor of the CMS module to move the Twig environment creation into the container avoiding the repetition of creation in the
CmsCompoundObjectand theController. It removes the controller dependency on theDebugExtensionwhich didn't seem necessary and it removes it from theCms\Twig\Extensionconstructor, which gets it instead from the Twig context.It shouldn't change any behaviour but this does fix an issue with the Pages plugin where the lack of
DebugExtensioncaused an issue