Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add files via upload #3

Closed
wants to merge 1 commit into from
Closed

Add files via upload #3

wants to merge 1 commit into from

Conversation

oggioniale
Copy link
Owner

No description provided.

@oggioniale
Copy link
Owner Author

@dalito I made a new PR, but once again I get an error (a new).

voc4cat 0.8.5
INFO    |Executing cmd: voc4cat check --config _main_branch/idranges.toml --logfile outbox/voc4cat.log --ci-pre inbox-excel-vocabs/ _main_branch/vocabularies
DEBUG   |Processing common options.
DEBUG   |Config loaded from: _main_branch/idranges.toml
DEBUG   |Check subcommand started!
DEBUG   |-> Found 1 xlsx files in "inbox-excel-vocabs"
DEBUG   |-> vocab name stems: 
DEBUG   |-> inbox name stems: vocab_datalevel
DEBUG   |-> config vocab names: datalevel
ERROR   |Terminating with Voc4cat error.
Traceback (most recent call last):
  File "/opt/hostedtoolcache/Python/3.12.7/x64/lib/python3.12/site-packages/voc4cat/cli.py", line 450, in run_cli_app
    main_cli(raw_args)
  File "/opt/hostedtoolcache/Python/3.12.7/x64/lib/python3.12/site-packages/voc4cat/cli.py", line 442, in main_cli
    args.func(args)
  File "/opt/hostedtoolcache/Python/3.12.7/x64/lib/python3.12/site-packages/voc4cat/check.py", line 164, in check
    validate_vocabulary_files_for_ci_workflow(vocab_dir, inbox_dir)
  File "/opt/hostedtoolcache/Python/3.12.7/x64/lib/python3.12/site-packages/voc4cat/checks.py", line 116, in validate_vocabulary_files_for_ci_workflow
    raise Voc4catError(msg % ", ".join(missing_in_config))
voc4cat.checks.Voc4catError: Missing vocabulary id_range config for "vocab_datalevel".

PS Why vocab name is data level and not with capital L?

@dalito
Copy link
Contributor

dalito commented Nov 28, 2024

I tried it out locally: The problem is that the Excel file must just be named just dataLevel.xlsx for the vocabuly "dataLevel" not vocab_dataLevel.xlsx.

The error message is in principle clear but one does not think about the excel file name as source of the problem. The excel filename determines which vocabulary is looked up in IDranges. This should be better documented and we should add a special check for this with a more meaningful error message.

@oggioniale oggioniale closed this Nov 28, 2024
@dalito
Copy link
Contributor

dalito commented Nov 28, 2024

You changed the Excel-Template version to 0.0.1 (on Introduction-sheet) but it should stay at 0.4.3. It is a version of the Excel-structure, not of the vocabulary contents.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants