Add track_caller attributes so that panic! sees the correct line number #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ic! calls This obviates the at_location setter
…needed with trace_caller
Some of test warnings are marked as allowed for now.
…e macros - the assert_that! and asserting! macros are no longer needed
|
@oknozor thoughts? This greatly improves the output and traced line #s. |
|
Thanks @urkle ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This obviates the need for at_location and the 2 macros. And this makes it so the line number hint printed by panic! is correct and IDE linking works as expected.
Also I bumped the edition to 2021 and applied clippy check adjustments.