Prefer resource method #323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #323 +/- ##
==========================================
+ Coverage 99.22% 99.24% +0.01%
==========================================
Files 13 13
Lines 519 528 +9
==========================================
+ Hits 515 524 +9
Misses 4 4
|
This is a way to change current behavior of when there are two methods with the same name, one on the resource and one on the object. Some say they prefer defining methods instead of using `attribute` since it's easier to type methods than type DSL. The problem is that methods on resource are not called if there's a method with the same name on the object. I understand this situation and I'd like to support it.
okuramasafumi
force-pushed
the
prefer-resource-method
branch
from
d64e010 to
ec58245
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#277 was closed while ago, and it's fully resolved!