fix: prevent floating point loop on fader level by setting step to 0.01

chore: better verbose logging
olzzon · Feb 14, 2020 · 263d016 · 263d016
1 parent 4e8233c
commit 263d016
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 1 deletion.
diff --git a/client/components/Channel.tsx b/client/components/Channel.tsx
@@ -109,6 +109,7 @@ class Channel extends React.Component<IChannelProps & IChannelInjectProps & Stor
                 animate={false}
                 range={{ min: 0, max: 1 }} 
                 start={[this.props.fader.faderLevel]} 
+                step={0.01}
                 connect
                 onSlide={(event: any) => {
                     this.handleLevel(event);

diff --git a/server/MainThreadHandler.ts b/server/MainThreadHandler.ts
@@ -395,6 +395,7 @@ export class MainThreadHandlers {
         )
         .on(SOCKET_SET_FADERLEVEL, (
             (payload: any) => {
+                logger.verbose('Set faderlevel  Channel : ' + String(payload.faderIndex + 1) + '  Level : ' + String(payload.level))
                 store.dispatch({
                     type: SET_FADER_LEVEL,
                     channel: payload.faderIndex,

diff --git a/server/utils/mixerConnections/OscMixerConnection.ts b/server/utils/mixerConnections/OscMixerConnection.ts
@@ -322,7 +322,6 @@ export class OscMixerConnection {
     pingMixerCommand() {
          //Ping OSC mixer if mixerProtocol needs it.
          this.mixerProtocol.pingCommand.map((command) => {
-            logger.verbose('Sending OSC command :' + command.mixerMessage, {})
             this.sendOutMessage(
                 command.mixerMessage,
                 0,
@@ -366,6 +365,7 @@ export class OscMixerConnection {
                 channelString
             );
         if (message != 'none') {
+            logger.verbose('Sending OSC command :' + message, {})
             this.oscConnection.send({
                 address: message,
                 args: [