NRF crash issue fix #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thakurajayL
reviewed
Nov 14, 2022
dbadapter/dbadapter.go
Outdated
| MongoDBLibrary.SetMongoDB(setdbName, url) | ||
| if MongoDBLibrary.Client != nil { | ||
| dbc.Client = MongoDBLibrary.Client | ||
| dbc.dbName = setdbName |
There was a problem hiding this comment.
Use new DB library now.
There was a problem hiding this comment.
util/mongoapi used. as per this library modifications are more. please go through changes
badhrinathpa
reviewed
Jan 9, 2023
producer/nf_management.go
Outdated
| client := &http.Client{} | ||
| _, err = client.Do(req) | ||
| if err != nil { | ||
| fmt.Println("Errored when sending request to the server") |
There was a problem hiding this comment.
lets print the error here
| @@ -2,14 +2,16 @@ module github.com/omec-project/nrf | |||
|
|
|||
| go 1.16 | |||
|
|
|||
| replace github.com/omec-project/nrf => ./ | |||
There was a problem hiding this comment.
we can remove this before merging right ?
There was a problem hiding this comment.
its ok to keep i think
| @@ -284,6 +286,19 @@ func NFDeregisterProcedure(nfInstanceID string) (problemDetails *models.ProblemD | |||
| return nil | |||
| } | |||
|
|
|||
| func sendNFDownNotification(nfProfile models.NfProfile, nfInstanceID string) { | |||
There was a problem hiding this comment.
Is this part of the spec notification model or a different API?
There was a problem hiding this comment.
its different API which i added to delete the keepalive entry of deregistred/crash pod from DB
vthiruveedula
force-pushed
the
master
branch
3 times, most recently
from
aaf7b79 to
56c7bf4
Compare
1. change owner of chunkids which were owned by
crash/deregistered pod
stop sending profile update notifications
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.