-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes CI to run unit tests #42
Conversation
Can you also please update the dependabot extension to |
Done |
Thanks! |
@gruyaume, why are the changes in |
My bad, these were an artefact from testing (because they have sleeps in them and take a while to run). I re-added them. |
Do you still need to make the import order change in |
Indeed, this change is not "needed", it's a linting improvement. I can remove it from this PR if you prefer. |
Are you planning to open a PR for linting improvements? If so, I would prefer to remove that change from this PR because those linting changes are not aligned to what this PR is about (Fix CI unit tests). Does it make sense? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 (tested changes locally)
Description
This PR fixes the existing CI workflow to run unit tests recursively and addresses various problems identified by
go test