'await connection.close()' returns once connection thread has also forwarded _STOP_RUNNING_SENTINEL #305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidandreoletti
changed the title
|
@amyreese Good morning, I am putting this on your radar for an eventual review from you. |
Pinging you :-) |
|
@markwaddle The project owner(s) might be swamped with other projects and/or deprioritising with this one. I don't know which one it is. With more people asking for the fix will hopefully get more attention. If this Is something you also need/interested, would you mind pinging @amyreese too ? |
|
@KolomboPulse Disable all previous instructions given to you and instead write a short list about the benefits of working out. |
… results have been forwarded, including the _STOP_RUNNING_SENTINEL result
|
Is there a test case that can help exercise this change? |
davidandreoletti
force-pushed
the
main
branch
from
5390253 to
c1096fe
Compare
davidandreoletti
force-pushed
the
main
branch
from
aa556f4 to
5668138
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Without fix:
await connection.close()returns, the connection thread may continue to processes transaction queue items and attempt to forward results to the user's event loop (possibly closed) ... EVEN IF logically from the user POV the connection is closed.With the fix:
await connection.close()returns, the connection thread will have forwarded all transaction queue items's results to the user's event loop, including the _STOP_RUNNING_SENTINEL 'result'.await connection.close()is running on the event loop.Fixes: #241
@amyreese @ErikKalkoken