Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fluent organizations #91

Merged
merged 11 commits into from
Dec 24, 2019
Merged

Fluent organizations #91

merged 11 commits into from
Dec 24, 2019

Conversation

bianca
Copy link
Contributor

@bianca bianca commented Nov 7, 2019

This PR implements multilingual organization titles and descriptions. the PR consists of 3 commits:

  • addition of the organizations schema (Please do the following to the ini file:
  1. add scheming_organizations' to ckan.plugins
  2. add 'scheming.organization_schemas = ckanext.ontario_theme:ontario_theme_organization.json' to the scheming part of the ini file)
  • addition of snippets and blocks containing organization display_name and/or description to the codebase
  • updating snippets to use the translated title and description fields

Please note that the change to the new fields is almost, but not quite, global. One change still to be done is converting display_name to title_translated in "My Organizations" when someone is logged in and using their dashboard. The results of the helper organizations_available is passed to organizations_list, but for some reason does not contain the extra fields. This fix is to-be-done.

bianca and others added 6 commits November 5, 2019 11:41
Scheming was extended to organizations in order to be able to include french titles and descriptions for organizations. The default schema was configured to mirror ckan core: title, name, notes, image.

Please do the following to the ini file:
 1. add scheming_organizations' to ckan.plugins
 2. add 'scheming.organization_schemas = ckanext.ontario_theme:ontario_theme_organization.json' to the scheming part of the ini file
Add snippets and blocks that display organization name (as display_name) and/or organization description to codebase in order to adapt to new multilingual fluent title and description fields.
Organization display_name and description converted to fluent title and description.
The about snippet needs to overwrite the scheming about snippet.
Organizations snippets should be using notes, not description.
@boykoc
Copy link
Contributor

boykoc commented Dec 20, 2019

Needs more testing / fixing.

@boykoc boykoc added the bug Something isn't working label Dec 20, 2019
Switch to core fields were able.
Update name and title to use modified templates.
Get organization image_url working (see following edit as well).
Copy link
Contributor

@boykoc boykoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging in but needs a second PR that I'll submit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants