Fluent organizations #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Scheming was extended to organizations in order to be able to include french titles and descriptions for organizations. The default schema was configured to mirror ckan core: title, name, notes, image. Please do the following to the ini file: 1. add scheming_organizations' to ckan.plugins 2. add 'scheming.organization_schemas = ckanext.ontario_theme:ontario_theme_organization.json' to the scheming part of the ini file
Add snippets and blocks that display organization name (as display_name) and/or organization description to codebase in order to adapt to new multilingual fluent title and description fields.
Organization display_name and description converted to fluent title and description.
The about snippet needs to overwrite the scheming about snippet.
Organizations snippets should be using notes, not description.
|
Needs more testing / fixing. |
Switch to core fields were able. Update name and title to use modified templates. Get organization image_url working (see following edit as well).
boykoc
approved these changes
Dec 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements multilingual organization titles and descriptions. the PR consists of 3 commits:
Please note that the change to the new fields is almost, but not quite, global. One change still to be done is converting display_name to title_translated in "My Organizations" when someone is logged in and using their dashboard. The results of the helper organizations_available is passed to organizations_list, but for some reason does not contain the extra fields. This fix is to-be-done.