Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some user menu buttons aren't synced #118

Closed
polycone opened this issue Jun 23, 2023 · 2 comments
Closed

Some user menu buttons aren't synced #118

polycone opened this issue Jun 23, 2023 · 2 comments
Labels
bug Something isn't working
Milestone
[Alpha] Bare minimum

Comments

@polycone
Copy link
Member

image

I clicked on Cancel Dig on the server and that action hadn't happened on the client.
The same is for Cancel Mop.

Note: I haven't checked all the buttons.
@polycone polycone added the bug Something isn't working label Jun 23, 2023
@polycone polycone added this to the [Alpha] Bare minimum milestone Jun 23, 2023
@zuev93
Copy link
Member

zuev93 commented Jul 2, 2023

Checked:
This is caused due to KPrefabeId desyncs. This is happening for new objects that are created after a sync.

Sync in general works.

So after #126 is complete we need to switch from KPrefabeId to our own MultiplayerIds and the sync will work reliably.

zuev93 added a commit that referenced this issue Jul 3, 2023
@zuev93
#118 Replace KPrefabeId usage with MultiplayerId.
8b61431 
This is more reliable way to identify objects and sync those created after hard sync.
zuev93 added a commit that referenced this issue Jul 3, 2023
@zuev93
#118 Replace KPrefabeId usage with MultiplayerId.
4a192c5 
This is more reliable way to identify objects and sync those created after hard sync.
zuev93 added a commit that referenced this issue Jul 3, 2023
@zuev93
#118 Replace KPrefabeId usage with MultiplayerId.
79c2034 
This is more reliable way to identify objects and sync those created after hard sync.
zuev93 added a commit that referenced this issue Jul 3, 2023
@zuev93
#118 Replace KPrefabeId usage with MultiplayerId.
034d3ff 
This is more reliable way to identify objects and sync those created after hard sync.
zuev93 added a commit that referenced this issue Jul 3, 2023
@zuev93
#118 Replace KPrefabeId usage with MultiplayerId.
f7abb20 
This is more reliable way to identify objects and sync those created after hard sync.
zuev93 added a commit that referenced this issue Jul 3, 2023
@zuev93
#118 Use static logger.
9561bee
@polycone polycone moved this to Todo in Multiplayer Mod Jul 4, 2023
@zuev93
Copy link
Member

zuev93 commented Jul 13, 2023

So user menu patch switched to MultiplayerReference and works as other sync patches.

In meanwhile this bug still reproducable for non synced building ghost.

We have a ticket to sync building MultiplayerIds which will eventyually fix this bug. Therefore closing this ticket in favor of #133

@zuev93 zuev93 closed this as completed Jul 13, 2023
@github-project-automation github-project-automation bot moved this from Todo to Done in Multiplayer Mod Jul 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
Multiplayer Mod
Archived in project
Milestone
[Alpha] Bare minimum
Development

No branches or pull requests
2 participants
@zuev93 @polycone