Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Game crashes if Door class is patched #183

Closed
polycone opened this issue Jul 28, 2023 · 0 comments · Fixed by #184
Closed

Game crashes if Door class is patched #183

polycone opened this issue Jul 28, 2023 · 0 comments · Fixed by #184
Assignees
@polycone
Labels
bug Something isn't working critical A critical issue tech Technical feature
Milestone
[Alpha] Bare minimum

Comments

@polycone
Copy link
Member

polycone commented Jul 28, 2023 •
edited
Loading

Steps to reproduce:

  1. Patch any Door method with an empty patch
  2. Load saved game with some doors
  3. Click Lock on any door
  4. Un-pause game

The reason is static field Door.OVERRIDE_ANIMS is being initialized during the detour process before assets are available.

(https://forums.kleientertainment.com/forums/topic/149951-simple-empty-mod-causes-game-to-crash/)
@polycone polycone added bug Something isn't working tech Technical feature labels Jul 28, 2023
@polycone polycone added this to the [Alpha] Bare minimum milestone Jul 28, 2023
@polycone polycone self-assigned this Jul 28, 2023
@polycone polycone moved this to In Progress in Multiplayer Mod Jul 28, 2023
polycone added a commit that referenced this issue Jul 28, 2023
@polycone
#183 Add delayed mod loader
7199ddc
polycone added a commit that referenced this issue Jul 28, 2023
@polycone
#183 Add delayed mod loader
0b1dd2b
@polycone polycone linked a pull request Jul 28, 2023 that will close this issue
#183 Add delayed mod loader #184
Merged
@polycone polycone added the critical A critical issue label Jul 28, 2023
polycone added a commit that referenced this issue Jul 29, 2023
@polycone
#183 Add delayed mod loader (#184)
316a148
@github-project-automation github-project-automation bot moved this from In Progress to Done in Multiplayer Mod Jul 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@polycone polycone

Labels
bug Something isn't working critical A critical issue tech Technical feature
Projects
Multiplayer Mod
Status: Done
Milestone
[Alpha] Bare minimum
Development

Successfully merging a pull request may close this issue.

#183 Add delayed mod loader onimp/oni_multiplayer
1 participant
@polycone