Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install script does not work for non C:/ documents location #87

Closed
edunad opened this issue Jun 1, 2023 · 8 comments
Closed

Install script does not work for non C:/ documents location #87

edunad opened this issue Jun 1, 2023 · 8 comments
Labels
enhancement New feature or request

Comments

@edunad
Copy link

edunad commented Jun 1, 2023

I've noticed the install script does not work for users where the documents folder has been moved from C:/

The following script will fix it :

@echo off

FOR /F "tokens=2* skip=2" %%a in ('reg query "HKCU\Software\Microsoft\Windows\CurrentVersion\Explorer\User Shell Folders" /v "personal"') do set DocumentsFolder=%%b

echo "Installing multiplayer mod in folder: %DocumentsFolder%\Documents\Klei\OxygenNotIncluded\mods\Local\MultiplayerMod\"
xcopy /s .\MultiplayerMod %DocumentsFolder%\Documents\Klei\OxygenNotIncluded\mods\Local\MultiplayerMod\
@edunad edunad changed the title Install script does not work for non-C:/ documents location Install script does not work for non C:/ documents location Jun 1, 2023
@zuev93
Copy link
Member

zuev93 commented Jun 2, 2023

Thanks for the provided script!

Also do not hesitate to create fork and add your script to the repo (if you'd like to )

@edunad
Copy link
Author

edunad commented Jun 2, 2023

Thanks for the provided script!

Also do not hesitate to create fork and add your script to the repo (if you'd like to )

Wanted to create a fork, but wasn't sure where the script generation was happening, haven't delved into the code that much yet xD

@zuev93
Copy link
Member

zuev93 commented Jun 2, 2023

I haven't added a script to the build pipeline yet :)
So I've just manually added the bat file while preparing release zip file.

@edunad
Copy link
Author

edunad commented Jun 4, 2023

I'm attempting to setup the CI/CD using github actions, i'll add the script there :)

@edunad
Copy link
Author

edunad commented Jun 10, 2023

@zuev93 I've tried a few things to get the github actions working, but, I'm not sure if we are allowed to copy over the oni dlls (specifically Assembly-CSharp & Assembly-CSharp-firstpass) and place them somewhere in a folder for development 🤔.

@zuev93
Copy link
Member

zuev93 commented Jun 10, 2023

Me neither.

On some Klei forum I've seen messages that the KLEI are fine with modders decompiling Asssembly-CSharp & firstpass.
However I'd avoid copy pasting their dlls to game repo due to license and outdating reasons.

Is it feasible to setup custom goal in csproj/solution files to have zip file created upon release build/other action?
Because dropping ready zip archive to github is not a big deal.

@edunad
Copy link
Author

edunad commented Jun 11, 2023

I'll give it a try, worst case it's a .bat that compiles, zips and uploads to github for you

@zuev93
Copy link
Member

zuev93 commented Jul 15, 2023

I've added your bat script to the repo. So closing this issue for now.

@zuev93 zuev93 closed this as completed Jul 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants