Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom verification for DepthToSpace and SpaceToDepth operators. #915

Merged
merged 2 commits into from
Oct 16, 2021

Conversation

etiotto
Copy link
Collaborator

@etiotto etiotto commented Oct 14, 2021

This PR adds custom verify methods for the DepthToSpace and SpaceToDepth operators to check that:

  • input tensor has 4 dims
  • blocksize is strictly positive and divides the appropriate input tensor dimension(s) without remainder

@etiotto etiotto self-assigned this Oct 14, 2021
Copy link
Collaborator

@AlexandreEichenberger AlexandreEichenberger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlexandreEichenberger
Copy link
Collaborator

@jenkins-droid test this please

@etiotto etiotto changed the title Add custom verification for DepthToSpace and SpaceToDept operators. Add custom verification for DepthToSpace and SpaceToDepth operators. Oct 14, 2021
@etiotto etiotto merged commit 92b9844 into master Oct 16, 2021
@etiotto etiotto deleted the verify_depth_to_space branch October 16, 2021 17:55
@jenkins-droid
Copy link
Collaborator

Jenkins Linux ppc64le Build #1368 [push] Add custom verification ... started at 13:58

@jenkins-droid
Copy link
Collaborator

Jenkins Linux s390x Build #2258 [push] Add custom verification ... started at 13:56

@jenkins-droid
Copy link
Collaborator

Jenkins Linux amd64 Build #2259 [push] Add custom verification ... started at 12:57

@jenkins-droid
Copy link
Collaborator

Jenkins Linux s390x Build #2258 [push] Add custom verification ... passed after 1 hr 3 min

@jenkins-droid
Copy link
Collaborator

Jenkins Linux amd64 Build #2259 [push] Add custom verification ... passed after 1 hr 5 min

@jenkins-droid
Copy link
Collaborator

Jenkins Linux ppc64le Build #1368 [push] Add custom verification ... passed after 1 hr 18 min

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for DepthToSpace operator Support for SpaceToDepth operator
3 participants