Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Salesforce connector #3561

Merged
merged 1 commit into from
Dec 29, 2024
Merged

Improve Salesforce connector #3561

merged 1 commit into from
Dec 29, 2024

Conversation

hagen-danswer
Copy link
Contributor

Description

  • we now finish retrieving all information for 200 docs and then yield those out in batches rather than doing every single one and then yielding
  • updated section generation logic to support sectional permission censoring
  • general code cleanup

How Has This Been Tested?

  • wrote one basic test
  • tested by hand

Backporting (check the box to trigger backport action)

Note: You have to check that the action passes, otherwise resolve the conflicts manually and tag the patches.

  • This PR should be backported (make sure to check that the backport attempt succeeds)

Copy link

vercel bot commented Dec 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
internal-search ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 29, 2024 9:25pm

@Weves Weves added this pull request to the merge queue Dec 29, 2024
@Weves Weves removed this pull request from the merge queue due to a manual request Dec 29, 2024
@Weves Weves merged commit d14ef43 into main Dec 29, 2024
13 checks passed
@Weves Weves deleted the refactor-salesforce-connector branch December 29, 2024 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants