Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combined Persona and Prompt API #3690

Merged
merged 6 commits into from
Jan 17, 2025
Merged

Conversation

hagen-danswer
Copy link
Contributor

@hagen-danswer hagen-danswer commented Jan 16, 2025

Description

  • got rid of all prompt apis
  • created a new file to perform all prompt db operations
  • prompt manipulation happens exclusively through persona api calls
    • this has the benefit of not creating orphan prompts
    • it was 1:1 anyways so this is simpler to keep more logic on the backend
  • bugfix for attaching personas to groups
  • bugfix this Curators can't edit Public Assistants #3680
  • deleted a lot of unused code for clarity

How Has This Been Tested?

  • tested with an admin
    • ability to manipulate all assistants
  • tested with curator
    • ability to manipulate assistants they have created
    • ability to manipulate assistants that belong exclusively to groups they curate
  • tested with basic user
    • ability to manipulate assistants they have created

Backporting (check the box to trigger backport action)

Note: You have to check that the action passes, otherwise resolve the conflicts manually and tag the patches.

  • This PR should be backported (make sure to check that the backport attempt succeeds)

Copy link

vercel bot commented Jan 16, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
internal-search ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 17, 2025 7:49pm

@pablonyx
Copy link
Contributor

Looks good now! Tested creating, updating prompts on multi tenant and single tenant locally

@hagen-danswer hagen-danswer added this pull request to the merge queue Jan 17, 2025
Merged via the queue into main with commit 1ad2128 Jan 17, 2025
12 of 13 checks passed
@hagen-danswer hagen-danswer deleted the fix-persona-update-validation branch January 17, 2025 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants