Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed logic to search first message, fixed query override #3812

Merged
merged 1 commit into from
Jan 29, 2025

Conversation

evan-danswer
Copy link
Contributor

@evan-danswer evan-danswer commented Jan 28, 2025

Description

https://linear.app/danswer/issue/DAN-1353/query-override-fix-for-api

  • No more logic to run the original user message as-is. This wasn't actually happening in the current state of main, and we decided to leave it this way.
  • Now query override actually works again, i.e. when one hits process_message.py through a message request, it makes the search tool use that query. This will now only happen when someone is directly hitting our API due to the first bullet point.

How Has This Been Tested?

tested in UI and unit tested, although nothing works unless I set ToolCallSummary to have class Config: arbitrary_types_allowed = True. Didn't add that to the PR since I assume it's a package version thing, but we should probably look at it at some point.

Backporting (check the box to trigger backport action)

Note: You have to check that the action passes, otherwise resolve the conflicts manually and tag the patches.

  • This PR should be backported (make sure to check that the backport attempt succeeds)
  • [Optional] Override Linear Check

Copy link

vercel bot commented Jan 28, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
internal-search ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 28, 2025 7:23pm

@evan-danswer evan-danswer added this pull request to the merge queue Jan 29, 2025
Merged via the queue into main with commit a0470a9 Jan 29, 2025
14 of 15 checks passed
@evan-danswer evan-danswer deleted the query-override-API-only branch January 29, 2025 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants