Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow no search #3903

Merged
merged 1 commit into from
Feb 6, 2025
Merged

Allow no search #3903

merged 1 commit into from
Feb 6, 2025

Conversation

pablonyx
Copy link
Contributor

@pablonyx pablonyx commented Feb 5, 2025

Description

Allows for Slackbots that do not have search enabled

How Has This Been Tested?

  • Search default
  • Non-search defaults
  • Documents sets
  • Various assistants
  • Downgrade from search available assistant

Backporting (check the box to trigger backport action)

Note: You have to check that the action passes, otherwise resolve the conflicts manually and tag the patches.

  • This PR should be backported (make sure to check that the backport attempt succeeds)
  • [Optional] Override Linear Check

Copy link

vercel bot commented Feb 5, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
internal-search ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 6, 2025 3:22am

@@ -194,7 +205,7 @@ export function SlackChannelConfigFormFields({
<>
<label
htmlFor="channel_name"
className="block font-medium text-base mb-2"
className="block text-text font-medium text-base mb-2"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

extra space?

@pablonyx pablonyx force-pushed the slack_channel_default_config branch from 70bfbb8 to 7153cb0 Compare February 5, 2025 22:27
@pablonyx pablonyx changed the base branch from slack_channel_default_config to main February 5, 2025 22:31
@pablonyx pablonyx enabled auto-merge February 5, 2025 22:36
@pablonyx pablonyx added this pull request to the merge queue Feb 6, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 6, 2025
@pablonyx pablonyx merged commit 396f096 into main Feb 6, 2025
8 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants