Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce background errors #4004

Merged
merged 4 commits into from
Feb 15, 2025
Merged

Reduce background errors #4004

merged 4 commits into from
Feb 15, 2025

Conversation

pablonyx
Copy link
Contributor

@pablonyx pablonyx commented Feb 14, 2025

Description

Primary

  1. Lock Reacquisition Error
    • Leads to Lock not owned on completion for Vespa sync task
    • Possibly caused by high latency operations (occurs for high doc count tenants)
    • Added some logging
    • Status: Unresolved

Monitoring

  1. Missing Sync Record

    • Address No sync record found for (doc_set) errors
    • Caused by unsuccessful creation of sync records for doc sets
    • Occurs in monitor_document_set_taskset function
    • Status: Resolved (warning may persist temporarily)
  2. Non-initial Index Attempt

    • Address incorrect assumptions about reindexing non-refresh freq connectors

API Server

  1. KV Store Settings Error

    • Fix Error loading settings from KV Store
    • Empty custom Exception class not logging in error logs
    • Status: Resolved / should be debuggable now
  2. API Server Spam

    • Reduce unnecessary 404s / auth related spam

Heavy

  1. TTL Management Task Error

    • Handle ValueError('Chat session has been deleted') in perform_ttl_management_task
    • Improper handling of already deleted chat sessions
    • Status: Resolved
  2. Minor logging improvements

General Issues

  • Handle relation "key_value_store" does not exist errors
    • Deleted non-existent tenant accounts that were still being synced by our control plane

How Has This Been Tested?

[Describe the tests you ran to verify your changes]

Backporting (check the box to trigger backport action)

Note: You have to check that the action passes, otherwise resolve the conflicts manually and tag the patches.

  • This PR should be backported (make sure to check that the backport attempt succeeds)
  • [Optional] Override Linear Check

Copy link

vercel bot commented Feb 14, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
internal-search ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 15, 2025 1:37am

except Exception:
task_logger.exception(
"update_sync_record_status exceptioned. "
f"document_set_id={document_set_id}"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

trailing space here probably needed

@pablonyx pablonyx merged commit 697f8bc into main Feb 15, 2025
7 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants