Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

By default, use primary LLM for initial & refined answer #4012

Merged
merged 2 commits into from
Feb 17, 2025

Conversation

joachim-danswer
Copy link
Contributor

Use of new env variable

Description

Unless specified in an environment variable, the primary LLM should be used to generate initial and refined answer.

Addressed through new environment var AGENT_ANSWER_GENERATION_BY_FAST_LLM

Linear: https://linear.app/danswer/issue/DAN-1455/use-primary-llms-as-default-llm-for-initial-and-refined-answer

How Has This Been Tested?

Locally.Run w/ and w/o this variable set.

Backporting (check the box to trigger backport action)

Note: You have to check that the action passes, otherwise resolve the conflicts manually and tag the patches.

  • This PR should be backported (make sure to check that the backport attempt succeeds)
  • [Optional] Override Linear Check

Copy link

vercel bot commented Feb 15, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
internal-search ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 16, 2025 10:24pm

Copy link
Contributor

@evan-danswer evan-danswer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joachim-danswer
Copy link
Contributor Author

I still think that we should also set an override parameter...

@joachim-danswer joachim-danswer added this pull request to the merge queue Feb 16, 2025
Merged via the queue into main with commit 20d3efc Feb 17, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants