Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make Settings model match db #4087

Merged
merged 1 commit into from
Feb 24, 2025
Merged

make Settings model match db #4087

merged 1 commit into from
Feb 24, 2025

Conversation

evan-danswer
Copy link
Contributor

@evan-danswer evan-danswer commented Feb 21, 2025

Description

Backend errors causing misconfigured message due to newly nullable settings being loaded into pydantic models without matching None type as a possibility

How Has This Been Tested?

n/a

Backporting (check the box to trigger backport action)

Note: You have to check that the action passes, otherwise resolve the conflicts manually and tag the patches.

  • This PR should be backported (make sure to check that the backport attempt succeeds)
  • [Optional] Override Linear Check

Copy link

vercel bot commented Feb 21, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
internal-search ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 24, 2025 6:19pm

@evan-danswer evan-danswer force-pushed the pydantic-settings-None branch from 09adde7 to 72e5a98 Compare February 24, 2025 18:15
@evan-danswer evan-danswer added this pull request to the merge queue Feb 24, 2025
Merged via the queue into main with commit 076619c Feb 24, 2025
10 checks passed
@evan-danswer evan-danswer deleted the pydantic-settings-None branch February 24, 2025 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants