Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to index all Jira projects #4106

Merged
merged 4 commits into from
Feb 25, 2025
Merged

Conversation

Weves
Copy link
Contributor

@Weves Weves commented Feb 24, 2025

Description

https://linear.app/danswer/issue/DAN-1482/add-ability-to-pull-in-all-jira-projects-with-a-single-connector

How Has This Been Tested?

  • creating a connector with main + upgrading to this new version + verifying old connector still works
  • creating a connector with no project specfieid
  • creating a connector with a project specified

Backporting (check the box to trigger backport action)

Note: You have to check that the action passes, otherwise resolve the conflicts manually and tag the patches.

  • This PR should be backported (make sure to check that the backport attempt succeeds)
  • [Optional] Override Linear Check

Copy link

vercel bot commented Feb 24, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
internal-search ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 25, 2025 1:28am

except Exception as e:
status_code = getattr(e, "status_code", None)

if status_code == 401:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

usually avoid elses after return/raise.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

addressed!

@Weves Weves enabled auto-merge February 25, 2025 01:26
@Weves Weves added this pull request to the merge queue Feb 25, 2025
Merged via the queue into main with commit a99dd05 Feb 25, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants