Improved chat search #4137
Merged
Improved chat search #4137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
rkuo-danswer
approved these changes
Feb 26, 2025
backend/onyx/db/chat_search.py
Outdated
|
|
||
| return list(chat_sessions), has_more | ||
| return sessions, has_more |
There was a problem hiding this comment.
see what list[] was removed for?
There was a problem hiding this comment.
Looks like it was causing some typing issues!
|
|
||
|
|
||
| def upgrade() -> None: | ||
| # Create a GIN index for full-text search on chat_message.message |
There was a problem hiding this comment.
add comments about why we needed this index and the improvement (per netflix context)
pablonyx
force-pushed
the
better_index
branch
from
865fa15 to
5bb6200
Compare
ahmadassaf
pushed a commit
to BeameryEdge/onyx
that referenced
this pull request
Mar 2, 2025
* functional + fast * k * adapt * k * nit * k * k * fix typing * k
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PR Description: Chat Search Optimization
Replaced the slow LIKE-based search with PostgreSQL full-text search using tsvector columns and GIN indexes
N.B. COMMIT statements in the migration are necessary because PostgreSQL requires CREATE INDEX CONCURRENTLY to run outside a transaction. Without them, the migration would fail with "CREATE INDEX CONCURRENTLY cannot run inside a transaction block"
How Has This Been Tested?
[Describe the tests you ran to verify your changes]
Backporting (check the box to trigger backport action)
Note: You have to check that the action passes, otherwise resolve the conflicts manually and tag the patches.