fix blowing up the entire task on exception and trying to reuse an in… #4179
+45
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ahmadassaf
pushed a commit
to BeameryEdge/onyx
that referenced
this pull request
Mar 4, 2025
onyx-dot-app#4179) * fix blowing up the entire task on exception and trying to reuse an invalid db session * list comprehension --------- Co-authored-by: Richard Kuo (Danswer) <[email protected]>
ahmadassaf
pushed a commit
to BeameryEdge/onyx
that referenced
this pull request
Mar 5, 2025
onyx-dot-app#4179) * fix blowing up the entire task on exception and trying to reuse an invalid db session * list comprehension --------- Co-authored-by: Richard Kuo (Danswer) <[email protected]> fix blowing up the entire task on exception and trying to reuse an in… (onyx-dot-app#4179) * fix blowing up the entire task on exception and trying to reuse an invalid db session * list comprehension --------- Co-authored-by: Richard Kuo (Danswer) <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…valid db session
Description
Fixes DAN-1512.
https://linear.app/danswer/issue/DAN-1512/fix-delete-chat-sessions-attempting-to-reuse-invalid-session
How Has This Been Tested?
[Describe the tests you ran to verify your changes]
Backporting (check the box to trigger backport action)
Note: You have to check that the action passes, otherwise resolve the conflicts manually and tag the patches.