Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(services): Networking Crate #1032

Merged
merged 1 commit into from
Feb 13, 2025
Merged

chore(services): Networking Crate #1032

merged 1 commit into from
Feb 13, 2025

Conversation

refcell
Copy link
Collaborator

@refcell refcell commented Feb 13, 2025

Description

Ports the P2P networking crate from hilo to kona.

@refcell refcell added A-workspace Area: workspace level modifications K-chore Kind: chore labels Feb 13, 2025
@refcell refcell self-assigned this Feb 13, 2025
@refcell
Copy link
Collaborator Author

refcell commented Feb 13, 2025

📚 $\text{Stack Overview}$

Pulls submitted in this stack:

This comment was automatically generated by st.

@refcell refcell force-pushed the feat/kona-net branch 2 times, most recently from 3db44cd to 609bc64 Compare February 13, 2025 17:35
Base automatically changed from monorepo to main February 13, 2025 17:36
Copy link

codecov bot commented Feb 13, 2025

Codecov Report

Attention: Patch coverage is 79.53964% with 160 lines in your changes missing coverage. Please review.

Project coverage is 84.7%. Comparing base (a7446de) to head (53659dc).
Report is 2 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
crates/services/net/src/gossip/driver.rs 6.3% 44 Missing ⚠️
crates/services/net/src/builder.rs 86.7% 31 Missing ⚠️
crates/services/net/src/discovery/driver.rs 51.9% 25 Missing ⚠️
crates/services/net/src/gossip/handler.rs 73.1% 25 Missing ⚠️
crates/services/net/src/driver.rs 0.0% 24 Missing ⚠️
crates/services/net/src/discovery/builder.rs 85.4% 8 Missing ⚠️
crates/services/net/src/gossip/event.rs 93.9% 2 Missing ⚠️
crates/services/net/src/gossip/behaviour.rs 97.6% 1 Missing ⚠️
Additional details and impacted files

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@refcell refcell force-pushed the feat/kona-net branch 3 times, most recently from 2e37975 to a077f6c Compare February 13, 2025 20:23
@clabby clabby added this pull request to the merge queue Feb 13, 2025
Merged via the queue into main with commit 96aba6a Feb 13, 2025
15 of 16 checks passed
@clabby clabby deleted the feat/kona-net branch February 13, 2025 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-workspace Area: workspace level modifications K-chore Kind: chore
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants