Refactor git-ls-files into a common utils function

test_notebooks.py

@@ -15,7 +15,8 @@
 import nbformat
 import pint
 import pytest
-from git.cmd import Git
+
+from .utils import find_files
 
 with warnings.catch_warnings():
     warnings.filterwarnings("ignore")
@@ -25,11 +26,7 @@
 
 
 @pytest.fixture(
-    params=(
-        path
-        for path in Git(Git(".").rev_parse("--show-toplevel")).ls_files().split("\n")
-        if path.endswith(".ipynb")
-    ),
+    params=find_files(file_extension=".ipynb"),
     name="notebook_filename",
 )
 def _notebook_filename(request):

test_todos_annotated.py

@@ -9,6 +9,8 @@
 from ghapi.all import GhApi, paged
 from git.cmd import Git
 
+from .utils import find_files
+
 
 def _grep(filepath, regex):
     reg_obj = re.compile(regex)
@@ -21,11 +23,7 @@ def _grep(filepath, regex):
 
 
 @pytest.fixture(
-    params=(
-        path
-        for path in Git(Git(".").rev_parse("--show-toplevel")).ls_files().split("\n")
-        if os.path.isfile(path)
-    ),
+    params=find_files(),
     name="git_tracked_file",
 )
 def _git_tracked_file(request):

utils.py

@@ -0,0 +1,26 @@
+"""
+Utils functions to reuse in different parts of the codebase
+"""
+import os
+
+from git.cmd import Git
+
+
+def find_files(path_to_folder_from_project_root=".", file_extension=None):
+    """
+    Returns all files in a current git repo.
+    The list of returned files may be filtered with `file_extension` param.
+    """
+    all_files = [
+        path
+        for path in Git(
+            Git(path_to_folder_from_project_root).rev_parse("--show-toplevel")
+        )
+        .ls_files()
+        .split("\n")
+        if os.path.isfile(path)
+    ]
+    if file_extension is not None:
+        return list(filter(lambda path: path.endswith(file_extension), all_files))
+
+    return all_files