-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add check if all notebooks have md with badges, md with description and Colab header #34
Conversation
Thank you @AgnieszkaZaba ! |
@slayoo Should I add definitions of badge functions to test_notebooks.py or is it better to use utils? |
This reverts commit 9d8744a.
I added badge functions to test_notebooks.py for now. There is a problem with empty.ipynb because it does not have proper structure. Should we change it or maybe exclude from those tests? |
👍
Let's either rename it to BTW, we maintain a set of "hints" for Python development here: https://github.com/open-atmos/python-dev-hints/wiki |
I added three tests proposed by @slayoo in #8. Changed order of cells in notebooks as:
In test_third_cell_contains_colab_header I set cell index as 2.