Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add enable/disable button to BNO055 interface #26

Merged
merged 3 commits into from
Mar 11, 2025
Merged

Add enable/disable button to BNO055 interface #26

merged 3 commits into from
Mar 11, 2025

Conversation

bparks13
Copy link
Member

@bparks13 bparks13 commented Mar 6, 2025

  • Standardize interface between NPX 1.0 and Bno 055, such as enable button placement

  • Automate creation of the Neuropixel legend during construction

  • Remove annotations, as they are not currently being used

  • Fixes Fill out the BNO055 Interface #23

- Standardize interface between NPX 1.0 and Bno 055, such as enable button placement
- Automate creation of the Neuropixel legend during construction
- Remove annotations, as they are not currently being used
@bparks13 bparks13 added this to the Neuropixels 1.0f milestone Mar 6, 2025
@bparks13 bparks13 requested a review from jonnew March 6, 2025 20:27
@bparks13 bparks13 self-assigned this Mar 6, 2025
@bparks13 bparks13 marked this pull request as ready for review March 6, 2025 20:27
- Use the enabled boolean value to enable or disable the device, and issue a context reset to make sure it is applied
Copy link

@jonnew jonnew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only comment i had during our review as to move the GUI element to the top left portion of the page.

@bparks13 bparks13 requested a review from jonnew March 10, 2025 18:14
- Correct tooltip information
Copy link

@jonnew jonnew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@bparks13 bparks13 merged commit 4ac8fe0 into main Mar 11, 2025
@bparks13 bparks13 deleted the issue-23 branch March 11, 2025 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fill out the BNO055 Interface
2 participants