-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add telemetry helper utils #1120
Conversation
Signed-off-by: Michael Beemer <[email protected]>
Signed-off-by: Michael Beemer <[email protected]>
Signed-off-by: Michael Beemer <[email protected]>
…lue attribute Signed-off-by: Michael Beemer <[email protected]>
Signed-off-by: Michael Beemer <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks semantically correct to me. Left a couple comments about style but they're really just nits. The one where the names don't match (code/type) is the only one that I think is an actual mistake.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Left two questions.
Signed-off-by: Michael Beemer <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Todd Baert <[email protected]>
…ror handling Signed-off-by: Michael Beemer <[email protected]>
🤖 I have created a release *beep* *boop* --- ## [1.7.0](core-v1.6.0...core-v1.7.0) (2025-02-07) ### ✨ New Features * add telemetry helper utils ([#1120](#1120)) ([1e93b3c](1e93b3c)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Signed-off-by: OpenFeature Bot <[email protected]>
This PR
Related Issues
Fixes #1118
Notes
I've omitted value type because it is likely to be declined in the OTel spec and adds complexity. We should consider removing that section from appendix d.