Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add telemetry helper utils #1120

Merged
merged 13 commits into from
Feb 7, 2025
Merged

Conversation

beeme1mr
Copy link
Member

@beeme1mr beeme1mr commented Jan 28, 2025

This PR

  • adds a method to core that returns a semantically valid flag evaluation event

Related Issues

Fixes #1118

Notes

I've omitted value type because it is likely to be declined in the OTel spec and adds complexity. We should consider removing that section from appendix d.

Signed-off-by: Michael Beemer <[email protected]>
@beeme1mr beeme1mr linked an issue Jan 28, 2025 that may be closed by this pull request
@beeme1mr beeme1mr marked this pull request as ready for review January 29, 2025 13:32
@beeme1mr beeme1mr requested a review from a team as a code owner January 29, 2025 13:32
Copy link

@dyladan dyladan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks semantically correct to me. Left a couple comments about style but they're really just nits. The one where the names don't match (code/type) is the only one that I think is an actual mistake.

Copy link
Member

@lukas-reining lukas-reining left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!
Left two questions.

Copy link

@dyladan dyladan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@beeme1mr beeme1mr added this pull request to the merge queue Feb 7, 2025
Merged via the queue into main with commit 1e93b3c Feb 7, 2025
9 checks passed
@beeme1mr beeme1mr deleted the 1118-implement-telemetryhook-in-js-sdk branch February 7, 2025 19:58
github-merge-queue bot pushed a commit that referenced this pull request Feb 7, 2025
🤖 I have created a release *beep* *boop*
---


##
[1.7.0](core-v1.6.0...core-v1.7.0)
(2025-02-07)


### ✨ New Features

* add telemetry helper utils
([#1120](#1120))
([1e93b3c](1e93b3c))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Signed-off-by: OpenFeature Bot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement TelemetryHook in JS SDK
5 participants