fix: msg missing when providers return err resolutions #1134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toddbaert
force-pushed
the
fix/inst-by-code-message
branch
2 times, most recently
from
5728172 to
fb70631
Compare
Signed-off-by: Todd Baert <[email protected]>
toddbaert
force-pushed
the
fix/inst-by-code-message
branch
from
fb70631 to
39076fa
Compare
beeme1mr
approved these changes
Feb 6, 2025
|
Merging because it's low risk and fixes a bug. |
This was referenced Feb 6, 2025
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 7, 2025
🤖 I have created a release *beep* *boop* --- ## [1.17.1](server-sdk-v1.17.0...server-sdk-v1.17.1) (2025-02-07) ### 🐛 Bug Fixes * msg missing when providers return err resolutions ([#1134](#1134)) ([bc9f6e4](bc9f6e4)) ### 🧹 Chore * update core peer ([8bbd43e](8bbd43e)) ### 📚 Documentation * fix eval context link ([#1132](#1132)) ([f6bc695](f6bc695)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Signed-off-by: OpenFeature Bot <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 7, 2025
🤖 I have created a release *beep* *boop* --- ## [1.4.1](web-sdk-v1.4.0...web-sdk-v1.4.1) (2025-02-07) ### 🐛 Bug Fixes * msg missing when providers return err resolutions ([#1134](#1134)) ([bc9f6e4](bc9f6e4)) ### 🧹 Chore * update core peer ([8bbd43e](8bbd43e)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Signed-off-by: OpenFeature Bot <[email protected]> Signed-off-by: Todd Baert <[email protected]> Co-authored-by: Todd Baert <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue where the error message was lost if a provider returned a resolution which had an error code (instead of throwing).
Frankly I don't think testing this is worth it. I debating making the second arg to this function
message: string | undefinedinstead ofmessage?: string(which would force a second arg to be set) but that would be breaking and we'd need to release a core v2 to avoid possible tsc issues in consumers, which I don't think is worth it ether.