Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Improve github actions #11

Merged
merged 1 commit into from
Nov 9, 2022
Merged

Conversation

josecolella
Copy link
Collaborator

This PR

  • Add support for macos, and windows
  • Add testing step
  • Add linting step

Related Issues

references #10

@josecolella josecolella force-pushed the feat/improve-github-actions branch 2 times, most recently from 54d3939 to df928ab Compare November 9, 2022 06:17
- Add support for macos, and windows
- Add testing step
- Add linting step

references #10

Signed-off-by: Jose Colella <[email protected]>
Copy link
Member

@beeme1mr beeme1mr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a lot of redundancy in this file. It would be nice to centralize parts of the configuration (e.g. the matrix section) but I'm not sure what's possible.

@josecolella
Copy link
Collaborator Author

There's a lot of redundancy in this file. It would be nice to centralize parts of the configuration (e.g. the matrix section) but I'm not sure what's possible.

@beeme1mr Agreed, there's this section on reusable workflows: https://docs.github.com/en/actions/using-workflows/reusing-workflows. I'll create a follow up to improve this

@josecolella
Copy link
Collaborator Author

#13 created

@josecolella josecolella merged commit 3f6c9b6 into main Nov 9, 2022
@josecolella josecolella deleted the feat/improve-github-actions branch November 9, 2022 15:25
@josecolella josecolella mentioned this pull request Nov 9, 2022
2 tasks
Copy link
Collaborator

@technicalpickles technicalpickles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍🏻

I was going to suggest splitting out Rubocop & RSpec so you get more targetted feedback, but figured you'd see that a little later on as you build this out.

matrix:
os: [ubuntu-latest, macos-latest, windows-latest]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will you be using any native dependencies, or having native extensions yourself? That would be the thing I'd be most worried about making sure to get good coverage across platforms.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't believe I will be using any native dependencies. The only dependency I have in mind is sorbet.
I added the different platforms to ensure that when we say we support development on linux, windows, and macos, that this is tested. Let's discuss more in our session

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants