Refactor creation of prepared queries #604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjungsbluth
force-pushed
the
expose_eval_prepare_opts
branch
2 times, most recently
from
9d006a5 to
8c49c01
Compare
|
I will add a note to the changelog As for tests: they cover all changes, however there never was coverage for passing options to the Eval method, I will add a minimal test. We‘ll also integrate this in Skipper to do partial evaluation on prepare as an optimization. So we‘ll know how well the changed API works design wise… |
2 tasks
mjungsbluth
force-pushed
the
expose_eval_prepare_opts
branch
2 times, most recently
from
2716c31 to
3e3484a
Compare
Before this refactoring only the PreparedQuery options could be passed when using this plugin as a library. There are two more options (prepare options and evaluation options) that can be passed when using the OPA library directly. This change breaks the interface but also allows for extensibility of creating the prepared queries in the future. Signed-off-by: Magnus Jungsbluth <[email protected]>
mjungsbluth
force-pushed
the
expose_eval_prepare_opts
branch
from
3e3484a to
1e06685
Compare
|
@ashutosh-narkar I added an item to the changelog and also added a test that verifies a user of a library can modify the existing behaviour. |
ashutosh-narkar
approved these changes
Oct 21, 2024
Pushpalanka
added a commit
to zalando/skipper
that referenced
this pull request
Jan 14, 2025
The EvalContext interface is added with new CreatePreparedQueryOnce function and the signature of envoyauth.Eval(ctx, opa, inputValue, result) method used by Skipper were changed with in OPA v0.70.0 as a result of open-policy-agent/opa-envoy-plugin#604. The interface change is absorbed with no functional addition and just addressing successful compilation. Signed-off-by: Pushpalanka Jayawardhana <[email protected]>
MustafaSaber
pushed a commit
to zalando/skipper
that referenced
this pull request
Jan 15, 2025
The EvalContext interface is added with new CreatePreparedQueryOnce function and the signature of envoyauth.Eval(ctx, opa, inputValue, result) method used by Skipper were changed with in OPA v0.70.0 as a result of open-policy-agent/opa-envoy-plugin#604. The interface change is absorbed with no functional addition and just addressing successful compilation. Signed-off-by: Pushpalanka Jayawardhana <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this refactoring only the PreparedQuery options could be passed when using this plugin as a library. There are two more options (prepare options and evaluation options) that can be passed when using the OPA library directly.
This change breaks the interface but also allows for extensibility of creating the prepared queries in the future.