topdown: improve scientific notation parsing in extractNumAndUnit #7147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
berdanA
force-pushed
the
Add-Scientific-Notation-7142
branch
from
a2b167e to
09e820d
Compare
| if !isNum(r) { | ||
| for idx := 0; idx < len(s); idx++ { | ||
| r := rune(s[idx]) | ||
| if !isNum(r) && r != 'e' && r != 'E' && r != '+' && r != '-' { |
There was a problem hiding this comment.
Adding a small note for this check will be helpful.
There was a problem hiding this comment.
I added a line comment explaining the check!
✅ Deploy Preview for openpolicyagent ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
berdanA
force-pushed
the
Add-Scientific-Notation-7142
branch
from
401c98e to
1715b72
Compare
|
@ashutosh-narkar alright, I tried to incorporate all the things that you listed. Docs are updated and the check is commented. I hope the changes are fine :) |
added 3 commits
November 8, 2024 12:36
- Updated extractNumAndUnit to recognize and correctly parse scientific notation, including cases with 'e' or 'E' followed by an exponent (e.g., "1e10", "3.2E4"). - Ensures that 'e' or 'E' is treated as part of the number if followed by digits, enhancing compatibility with scientific notation inputs. - Scientific notation with units now also parses correctly (e.g., "1e10GB" extracts "1e10" as the number and "GB" as the unit). - Maintains behavior for cases without units, allowing either the number or unit portion to be empty, while improving overall string parsing logic. - Added tests for scientific notation parsing in `units.parse_bytes`, including both SI and binary units (e.g., KB, MiB, GiB, KiB). - Included cases for uppercase, lowercase, and mixed case formats with scientific notation. - Added validation for numbers without units defaulting to bytes. Fixes open-policy-agent#7142 Signed-off-by: bakar <[email protected]>
… in units parsing - Added mention of scientific notation (e.g., "1e3", "2.5e6") support in `units.parse` and `units.parse_bytes`. - Included examples demonstrating how scientific notation can be used with both standard metric and binary units. Fixes open-policy-agent#7142 Signed-off-by: bakar <[email protected]>
Fixes open-policy-agent#7142 Signed-off-by: bakar <[email protected]>
ashutosh-narkar
force-pushed
the
Add-Scientific-Notation-7142
branch
from
b4dc054 to
b78435f
Compare
ashutosh-narkar
approved these changes
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why the changes in this PR are needed?
In the units.parser (or specifically in the extractNumAndUnit function in topdown/parse_bytes.go), scientific notation is not currently supported for parsing numeric values with units. This limitation impacts functionality when using OPA Gatekeeper as the policy engine in Kubernetes clusters, where certain resource specifications permit the use of scientific notation. To maintain flexibility and improve user experience, I would like to propose a solution that adds support for scientific notation without altering existing functionality.
What are the changes in this PR?
units.parse_bytes, including both SI and binary units (e.g., KB, MiB, GiB, KiB).Fixes #7142
Signed-off-by: Berdan Akar [email protected]