provide a more useful error message when there are conflicting default rules #7164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for openpolicyagent ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
tjons
force-pushed
the
tjons/6897-regotypeerror-ux
branch
3 times, most recently
from
58a45ec to
f22a71c
Compare
…t rules Signed-off-by: Tyler Schade <[email protected]>
tjons
force-pushed
the
tjons/6897-regotypeerror-ux
branch
from
f22a71c to
61b6d29
Compare
srenatus
approved these changes
Nov 12, 2024
| @@ -2068,7 +2068,7 @@ func TestCompilerCheckRuleConflictsDotsInRuleHeads(t *testing.T) { | |||
| `package pkg.p | |||
| default q.w.r = 4 | |||
| q.w.r = 2`), | |||
| err: "rego_type_error: multiple default rules data.pkg.p.q.w.r found", | |||
| err: "rego_type_error: multiple default rules data.pkg.p.q.w.r found at mod0.rego:2, mod1.rego:2", | |||
There was a problem hiding this comment.
I'm a little surprised that the ordering here is stable across test re-runs without sorting the defaultRules slice. But if that's the case, fine; we can fix it if it ever becomes a problem later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why the changes in this PR are needed?
Resolves #6897.
When there are multiple default rules in a package, the OPA compiler will error out with an unhelpful error message only providing the location of one default rule. This is confusing for users and can be improved by adding all default rule locations to the error message.
What are the changes in this PR?
Provide the location of all default rules in the resultant error when there are more than one default rule in the fileset compiled.
Notes to assist PR review:
Further comments: