Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bundle: Optimizing rego-version management in bundle activation #7296

Conversation

johanfylling
Copy link
Contributor

Only writing a module's rego-version to storage if it diverges from the runtime rego-version.

Only writing a module's rego-version to storage if it diverges from the runtime rego-version.

Signed-off-by: Johan Fylling <[email protected]>
Copy link
Member

@ashutosh-narkar ashutosh-narkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just to confirm we already fallback to the runtime rego-version on the read path as well, correct?

@johanfylling
Copy link
Contributor Author

we already fallback to the runtime rego-version on the read path as well, correct?

@ashutosh-narkar, correct 👍.

@johanfylling johanfylling merged commit e47bd4f into open-policy-agent:main Jan 24, 2025
28 checks passed
@johanfylling johanfylling deleted the optimize_bundle_activation_rego-version_management branch January 24, 2025 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants