-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable tracing for discovery plugin #7299
Enable tracing for discovery plugin #7299
Conversation
0a3a485
to
398442f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, but a test to verify this function works as expected would be good. In particular if it passed review once already without actually working :)
398442f
to
e4a3b34
Compare
Yes, fully agree. Are there already tests that prove tracing works? I might otherwise be a bit biased to proving it works as a library user (we have tests in Skipper for tracing but they also did not test discovery independently) |
There is one here. |
5e5cc25
to
06f9ab5
Compare
Ok, so I included another test. It currently validates that tracing for discovery and bundle download works. I can add the same for decision logs and status if needed. Two callouts:
|
270735e
to
e29734c
Compare
✅ Deploy Preview for openpolicyagent ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
09eaad1
to
73a213a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
73a213a
to
649752c
Compare
✅ Deploy Preview for openpolicyagent ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
649752c
to
7e58920
Compare
043b885
to
949358e
Compare
I changed all triggermodes to manual, this made the tests and the race detection stable |
@anderseknert could you have a final look (the only thing that changed since last time is manually triggering the plugins to make the tests stable)? |
Signed-off-by: Magnus Jungsbluth <[email protected]>
Signed-off-by: Magnus Jungsbluth <[email protected]>
Signed-off-by: Magnus Jungsbluth <[email protected]>
949358e
to
c424119
Compare
@mjungsbluth just did! Have rebased and will merge once the tests have run. |
This PR fixes an oversight introduced with #5973 that actually did not enable tracing for the discovery plugin.
This change centralizes the service options that are used for rest client creation on the plugin manager.