Eliminate allocation in Value.Find #7319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anderseknert
commented
Jan 27, 2025
| @@ -2375,15 +2376,18 @@ func (obj *object) Foreach(f func(*Term, *Term)) { | |||
| } | |||
|
|
|||
| // Map returns a new Object constructed by mapping each element in the object | |||
| // using the function f. | |||
| // using the function f. If f returns an error, the error is returned by Map. | |||
| // If f return a nil key, the element is skipped. | |||
There was a problem hiding this comment.
This feature isn't used anywhere in this PR, but that will follow in the next one 😎
srenatus
approved these changes
Jan 28, 2025
Mostly just some things I improved as I learnt more about how the storage system works. Reducing some allocations, and just general improvements. - Move some sync.Pool's to a common location - Allow object.Map to skip items when mapper returns nil key - Eliminate allocation in object.Find and array.Find when a scalar is encountered. - Use term pointer pool for temporary terms created only for the sake of calling object.Get in ptr.go Signed-off-by: Anders Eknert <[email protected]>
anderseknert
force-pushed
the
store-perf
branch
from
952099a to
cdcc7c4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly just some things I improved as I learnt more about how the storage system works. Reducing some allocations, and just general improvements.