Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed invalid links to examples (docs:ir) #7326

Merged
merged 1 commit into from
Jan 28, 2025

Conversation

JonathanDeLaCruzEncora
Copy link
Contributor

Updated links mentioned in #7320

Copy link

netlify bot commented Jan 28, 2025

Deploy Preview for openpolicyagent ready!

Name Link
🔨 Latest commit 425468b
🔍 Latest deploy log https://app.netlify.com/sites/openpolicyagent/deploys/67993d716b7462000803c375
😎 Deploy Preview https://deploy-preview-7326--openpolicyagent.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@anderseknert
Copy link
Member

Thank you! Looking at the "hello world" it looks like something got lost when moving that test from v0 to v1 — the v0 one had the comment with the information referred to here: https://github.com/open-policy-agent/opa/blob/main/v1/test/cases/testdata/v0/helloworld/test-helloworld-1.yaml

Could you please copy that over to the v1 one? Sorry that I didn't notice that before!

To pass the CNCF/DCO check you need to sign off your commit. You can just do this to add that:

git commit --amend --signoff
git push --force

Thanks!

@anderseknert anderseknert linked an issue Jan 28, 2025 that may be closed by this pull request
Signed-off-by: Jonathan De La Cruz <[email protected]>
@JonathanDeLaCruzEncora
Copy link
Contributor Author

Hello world updated, thanks for the help on DCO check!

Copy link
Member

@anderseknert anderseknert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 🙏

@ashutosh-narkar ashutosh-narkar merged commit b7397bb into open-policy-agent:main Jan 28, 2025
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docs(ir): invalid links to examples
3 participants